-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for Python 3.13 support #569
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR updates the project's Python version support to accommodate Python 3.13 while dropping support for Python 3.8 and 3.9. The change is implemented through updates to dependency specifications, GitHub workflow configurations, and code adjustments. The PR also includes preparation for a potential future migration from Poetry to uv package manager. Class diagram for updated dependencies in pyproject.tomlclassDiagram
class Project {
- version: String
- python: String
- scipy: String
- cftime: String
- dask: String
- h5netcdf: String
- xarray: String
- coverage: String
- pytest: String
- toml: String
}
note for Project "Updated Python version to >=3.10,<3.14 and scipy to >=1.14.1. Dropped support for Python 3.8 and 3.9."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @monocongo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the obsolete pearson3_workaround code entirely since it's now permanently set to False and the minimum scipy version (1.14.1) is well above where this workaround was needed (1.6.0).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Updates to allow for Python 3.13. Since we need the latest version of scipy which itself requires Python 3.10 we will have to drop support for 3.8 and 3.9 if this is merged.
Summary by Sourcery
Add support for Python 3.13 by updating dependencies and configuration, including scipy to version 1.14.1. Drop support for Python 3.8 and 3.9, and update CI to test against newer Python versions.
New Features:
Enhancements:
Build:
CI: