boot without connection & only print disconnected once #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
NB: I made the CLI options sys.exit(1) if no crow is found on boot because they would otherwise just load into the REPL if no device was found which seems incorrect behaviour for a CLI tool. Instead it returns with an errorcode and tells the user there's no crow detected.
Tbh I think we should drop that option (especially once filesystem navigation is include in the REPL), it feels like an odd inbetween thing to me.
simonvanderveldt
approved these changes
Oct 21, 2019
tehn
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43
fixes #14
Track whether a connection is currently active. Only print connect/disconnect on the state change.
On boot, run the 'reconnect' routine, which is essentially just connect that doesn't quit.
NB: I made the CLI options
sys.exit(1)if no crow is found on boot because they would otherwise just load into the REPL if no device was found which seems incorrect behaviour for a CLI tool. Instead it returns with an errorcode and tells the user there's no crow detected.