- Haptic Feedback added #34
Conversation
kamrankhan07
commented
Oct 8, 2018
kamrankhan07
commented
- Some code refactoring
- Menu Button rotate image is added
- Default values are changed
- Some code refactoring - Menu Button rotate image is added - Default values are changed
issue fix
Highlighted image made optional
Explode animation made optional
Default to true
Reverted animation back
|
Thanks for your pull request! I don't have enough time to develop this library, so I'm so grateful for your help. |
There was a problem hiding this comment.
@kamrankhan07 @kamrankhan-chilindo I appreciated your changes😂
But I found a few points to be discussed.
Please change it or describe your purpose.
| @objc open var expandingDirection: ExpandingDirection = .top | ||
| @objc open var menuTitleDirection: MenuTitleDirection = .left | ||
| open var expandingAnimations: CustomAnimationOptions = [.move, .menuButtonRotate] | ||
| open var foldingAnimations: CustomAnimationOptions = [.move, .menuButtonRotate] |
There was a problem hiding this comment.
Please use [.default] or please describe the reason why this value should be [.move, .menuButtonRotate].
There was a problem hiding this comment.
I will add default, I changed it because 'default' was using all animations and it was not desirable for me.
|
|
||
| @objc open var allowSounds: Bool = true { | ||
| @objc open var playSound: Bool = false { |
There was a problem hiding this comment.
Please use true or please describe the reason why this value should be false.
|
Thanks for your changes! I'll merge it. |
|
Thanks |
