Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop on compile error #380

Merged
merged 6 commits into from
Aug 11, 2020
Merged

Conversation

leevipietilainen
Copy link
Contributor

Fix #274 by introducing a new variable called stopOnFailure (default true) which allows tests to be run when typescript compile errors are present.

@leevipietilainen
Copy link
Contributor Author

hmm, postcss tests broke even though I didn't touch postcss module at all.

@erikbarke
Copy link
Collaborator

Hey @leevipietilainen, nice work!! This doesn't look like a breaking change (I'm a bit weary of them after #274...), so I guess this could be released as a v5.1.0, thoughts?

@leevipietilainen
Copy link
Contributor Author

Thanks! Yes, I'm fine with releasing this as v5.1.0.

@darlanalves
Copy link

darlanalves commented Jun 16, 2020

I just started testing in a pet project with karma-typescript and the first thing I bumped into was exactly this problem!

Thanks a lot for your change @leevipietilainen !
I was about to raise an issue and suggest a PR with a similar code :)

@erikbarke erikbarke merged commit 50fc185 into monounity:master Aug 11, 2020
@falsyvalues
Copy link

Thanks @leevipietilainen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change was introduced during PATCH change
4 participants