-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop on compile error #380
Conversation
hmm, postcss tests broke even though I didn't touch postcss module at all. |
Hey @leevipietilainen, nice work!! This doesn't look like a breaking change (I'm a bit weary of them after #274...), so I guess this could be released as a v5.1.0, thoughts? |
Thanks! Yes, I'm fine with releasing this as v5.1.0. |
I just started testing in a pet project with karma-typescript and the first thing I bumped into was exactly this problem! Thanks a lot for your change @leevipietilainen ! |
Thanks @leevipietilainen! |
Fix #274 by introducing a new variable called stopOnFailure (default true) which allows tests to be run when typescript compile errors are present.