Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to acorn@8.1.0 #442

Merged
merged 1 commit into from
Mar 15, 2021
Merged

chore: upgrade to acorn@8.1.0 #442

merged 1 commit into from
Mar 15, 2021

Conversation

vladjerca
Copy link
Contributor

@vladjerca vladjerca commented Mar 11, 2021

In version 8.0.3:

Fix a wasteful loop during Parser creation when setting ecmaVersion to "latest".

@vladjerca
Copy link
Contributor Author

Might relate to #435

On my end at least when using karma-typescript in conjuncition with karma-typescript-es6-transform, my tests would lock.

I found out it was locking here:

context.js.ast = acorn.parse(context.source, { sourceType: "module", ecmaVersion: "latest" });

This was caused to to an acorn bug which caused the parser to lock when using latest as the ecmaVersion. I've upgraded acorn in all packages and I've tested this locally.

@erikbarke
Copy link
Collaborator

Haha, "cool" detective work @vladjerca 😃

@erikbarke erikbarke merged commit d29945e into monounity:master Mar 15, 2021
@vladjerca vladjerca deleted the fix/update_acorn branch March 15, 2021 20:43
@vladjerca
Copy link
Contributor Author

@erikbarke any plans to publish any patch that includes this soon-ish? 😅

@erikbarke
Copy link
Collaborator

Now-ish 🤘 v5.5.1 is on npm now 🚀

@vladjerca
Copy link
Contributor Author

@erikbarke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants