Bug Fixes, Tests and LocalStorage Support #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carmandrew
commented
Nov 30, 2011
carmandrew
commented
- Fixed bugs that prevented it from running for me.
- Fixed multiple logic errors with resizing the cache.
- Added tests
- Changed to a pluggable backend storage model.
- Added a persistant localStorage backend model. This way the cache can be persistant across sessions.
- Updated documentation to reflect these changes.
…ing on resize to use the new cache size, instead of the old.
|
The first code review of your submits is OK for me (pending tests). Thanks for your support, this is exactly what we need, jscache is more robust and flexible now. |
monsur
added a commit
that referenced
this pull request
Nov 30, 2011
Bug Fixes, Tests and LocalStorage Support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.