Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array.find seems to be broken again #185

Closed
yang opened this issue Oct 25, 2017 · 8 comments
Closed

Array.find seems to be broken again #185

yang opened this issue Oct 25, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@yang
Copy link

yang commented Oct 25, 2017

Tested 5.0.7.

@hthetiot hthetiot added this to the 5.0.x milestone Dec 6, 2017
@hthetiot hthetiot self-assigned this Dec 6, 2017
@hthetiot hthetiot added the bug label Dec 6, 2017
@hthetiot
Copy link
Contributor

hthetiot commented Dec 6, 2017

Looking into it.

@hthetiot
Copy link
Contributor

hthetiot commented Dec 6, 2017

@yang Can you try npm install collections@2.0.3 that should fix your issue

I'm going to merge the overdue v2 branch in master and release v6 soon.
In the mean time I'm going to attempt to provide a fix to the recurring Array.prototype.find issue.

@hthetiot
Copy link
Contributor

hthetiot commented Dec 7, 2017

PR fix #188

@hthetiot
Copy link
Contributor

hthetiot commented Dec 7, 2017

@hthetiot hthetiot removed the wip label Dec 7, 2017
@hthetiot hthetiot closed this as completed Dec 7, 2017
@codebling
Copy link

Will check that out, thanks for the cc!

@codebling
Copy link

#162 is still broken

@erothmayer
Copy link

This appears to still be a problem (or another breaking change to the base language collections is similarly broken). In 5.1.8 3rd party libraries still have unexpected failures, while going back to 2.0.3 fixes them.

@codebling
Copy link

codebling commented Apr 15, 2019

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. As mentioned, branch v2 fixes these issues by avoiding global object modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants