Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all uses of blueprint to objectDescriptor #1856

Merged
merged 7 commits into from
Sep 14, 2017

Conversation

cdebost
Copy link
Collaborator

@cdebost cdebost commented Sep 6, 2017

Non breaking changes only. Removes all uses of blueprint from the codebase.

@cdebost cdebost added this to the v17.1.x API Enhancements milestone Sep 6, 2017
@cdebost cdebost self-assigned this Sep 6, 2017
@cdebost cdebost force-pushed the blueprint-to-object-descriptor branch 3 times, most recently from 79acb60 to 888da9f Compare September 6, 2017 21:52
@hthetiot hthetiot modified the milestones: v17.1.x API Enhancements, v17.1.1 Data and webcomponent Sep 8, 2017
@cdebost cdebost force-pushed the blueprint-to-object-descriptor branch from 8e0760a to 7d721ee Compare September 14, 2017 00:57
@marchant marchant merged commit 3abc69c into master Sep 14, 2017
@hthetiot
Copy link
Contributor

bluebird.min.js:29 Unhandled rejection TypeError: Cannot read property 'get' of undefined
    at eval (http://localhost:8085/test/spec/serialization/montage-deserializer-element-spec.js:72:48)
    at r (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:31:9004)
    at i._settlePromiseFromHandler (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:30:14217)
    at i._settlePromise (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:30:15020)
    at i._settlePromise0 (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:30:15721)
    at i._settlePromises (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:30:17051)
    at r._drainQueue (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:29:3056)
    at r._drainQueues (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:29:3117)
    at drainQueues (http://localhost:8085/node_modules/bluebird/js/browser/bluebird.min.js:29:1238)
    at <anonymous>
D @ bluebird.min.js:29
E @ bluebird.min.js:29
k @ bluebird.min.js:29
e._notifyUnhandledRejection @ bluebird.min.js:29
r._drainQueue @ bluebird.min.js:29
r._drainQueues @ bluebird.min.js:29
drainQueues @ bluebird.min.js:29
Promise resolved (async)
r @ bluebird.min.js:30
r._queueTick @ bluebird.min.js:29
o @ bluebird.min.js:29
p.hasDevTools.r.invoke @ bluebird.min.js:29
i._then @ bluebird.min.js:30
i.then @ bluebird.min.js:30
value @ montage-reviver.js:698
value @ montage-interpreter.js:206
value @ montage-interpreter.js:168
value @ montage-interpreter.js:34
value @ montage-deserializer.js:64
(anonymous) @ montage-deserializer-element-spec.js:70
attempt @ jasmine.js:4071
QueueRunner.run @ jasmine.js:3991
QueueRunner.execute @ jasmine.js:3973
queueRunnerFactory @ jasmine.js:828
Spec.execute @ jasmine.js:489
fn @ jasmine.js:5096
attempt @ jasmine.js:4071
QueueRunner.run @ jasmine.js:3991
runNext @ jasmine.js:4031
(anonymous) @ jasmine.js:4038
(anonymous) @ jasmine.js:3946
complete @ jasmine.js:496
runnerConfig.onComplete @ jasmine.js:486
(anonymous) @ jasmine.js:4005
channel.port1.onmessage @ jasmine.js:1645
jasmine-html.js:107 Spec 'serialization/montage-deserializer-element-spec Element Reference Deserialization should deserialize an element reference and add event listeners' has no expectations.

npm run test:jasmine

@hthetiot
Copy link
Contributor

screen shot 2017-09-19 at 4 09 08 pm

@hthetiot hthetiot deleted the blueprint-to-object-descriptor branch December 28, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants