List item menu #1929
Open
List item menu #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marchant
requested changes
Jul 11, 2018
| @@ -1371,6 +1374,7 @@ var TranslateComposer = exports.TranslateComposer = Composer.specialize(/** @len | |||
| translateEvent.initCustomEvent("translate", true, true, null); | |||
| translateEvent.translateX = this._translateX; | |||
| translateEvent.translateY = this._translateY; | |||
| translateEvent.targetElement = this.element; | |||
There was a problem hiding this comment.
Is this to workaround the fact that today the target is the translate composer itself?
| this.disabled = !hasLeftButtons && !hasRightButtons; | ||
| } | ||
|
|
||
| this._setButtonBoundaries(this._rightButtons, 'marginLeft'); |
There was a problem hiding this comment.
This is modifying the DOM in wilDraw, could it be moved at the beginning of draw instead?
| var hasLeftButtons = this._leftButtons && this._leftButtons.length > 0, | ||
| hasRightButtons = this._rightButtons && this._rightButtons.length > 0; | ||
|
|
||
| this._updateButtonPositions(); |
There was a problem hiding this comment.
This is modifying the DOM in wilDraw, could it be moved at the beginning of draw instead?
| dragElementStyle[ListItemMenu.cssTransition] = 'none'; | ||
|
|
||
| // Hide not sliding options. | ||
| if (isLeftSideOpened) { |
|
@marchant PR updated |
Limit of 3 per side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.