Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Control converter issue from user input #1948

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed Control converter issue from user input #1948

wants to merge 2 commits into from

Conversation

marchant
Copy link
Member

@marchant marchant commented Mar 6, 2018

  • fixes a control bug with converter in revert so it works while editing
  • adds a spec converter use cases for text field
  • code re-factoring of rotation composer,

@marchant
- code re-factoring of rotation composer,
c5b5347 
- fixes a control bug with converter in revert so it works while editing
- adds a spec converter use cases for text field
hthetiot
hthetiot reviewed Mar 6, 2018
View reviewed changes
Copy link
Contributor

@hthetiot hthetiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

test/all.js: line 101, col 5, Expected ']' to match '[' from line 3 and instead saw '{'.
test/all.js: line 101, col 6, Expected ')' and instead saw 'name'.
test/all.js: line 101, col 10, Missing semicolon.

test/all.js Outdated
@@ -97,6 +97,7 @@ module.exports = require("montage-testing").run(require, [
{name: "spec/ui/slot-spec", node: false},
{name: "spec/ui/substitution-spec", node: false},
{name: "spec/ui/text-input-spec", node: false},
{name: "spec/ui/control/text-field-spec", node: false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma

@hthetiot hthetiot added this to the v17.2.x Maintenance milestone Mar 6, 2018
@marchant
Copy link
Member Author

marchant commented Mar 6, 2018

Thanks @hthetiot pushed a fix

@hthetiot
Copy link
Contributor

hthetiot commented Mar 6, 2018

sry one more lint @benoitmarchant

ui/control.js: line 343, col 33, Misleading line break before '?'; readers may interpret this as an expression boundary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hthetiot hthetiot hthetiot left review comments

Assignees

@marchant marchant

Labels
None yet
Projects
None yet
Milestone
v17.2.x Maintenance
Development

Successfully merging this pull request may close these issues.
2 participants
@marchant @hthetiot