DataTrigger does not respect serializable attribute #1982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataTrigger.addTrigger()
overrides the getter and setter for a property on a prototype to route that property through montage-data. However,addTrigger()
does not include theserializable
attribute for that property as defined in the model.This means that if a prototype declares a property as not serializable:
A serialized instance of that class will not include
children
. This is expected.However, if DataTrigger.addTriggers() is called on the prototype and then we use the result to create an instance. That serialized instance will include
children
.