Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1971 #1988

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #1971 #1988

wants to merge 1 commit into from

Conversation

thibaultzanini
Copy link
Contributor

No description provided.

@tejaede
Copy link
Collaborator

tejaede commented Jun 27, 2018

To take a step back, I'm not sure I understand the value of a default label for button. The component does not need a label to work and I think the total amount of work for the developer is greater if button has a default.

If you boil down the possible options:

  1. No Label
  2. Label is the default
  3. Label is NOT the default

"Label is NOT the default" is going to require the same amount of work regardless so set that option aside.

For the others....
Without a default, "No Label" requires no code while "Label is the default" does.
With a default, "Label is the default" requires no code while "No Label" does.

In my eyes, "No Label" is significantly more likely than using the default so we should defer to the implementation that minimizes the work in that case.

Anecdotal evidence is here: https://github.com/thibaultzanini/montage/commit/14c94ebc202b93b091262ee6ed4eb16f1f865661#diff-b15e34a728b9cfd69f2e35b233b4d780

@thibaultzanini
Copy link
Contributor Author

@tejaede I agree it's more work for the developper. @marchant asked me to do that change for the studio and now I believe the studio should set this default value. FYI @cdebost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants