Fixed infra-860, bot did not delete previous comments #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bee-san
changed the title
bgandon
pushed a commit
to cloudfoundry-community/github-pr-resource
that referenced
this pull request
May 11, 2024
Indeed, in order to delete the correct comments, the golang code makes sure that comment's `Author.Login` is the same as current `Viewer.Login`. But with bot users, viewer's login is "githubApp[bot]" and author login is "githubApp". As a consequence, for the comparison to succeed, we need to remove any trailing "[bot]" suffix from both parties, and compare the resulting prefixes. This isue was originally submitted as telia-oss#245 and fixed later in monzo#4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved in #2
See my comments on the original forked repo:
telia-oss#245 (comment)
Copied below:
Hey 👋🏻
I had a similar issue, specifically:
The issue occurs here:
https://github.com/telia-oss/github-pr-resource/blob/9ec47e2d9f28d13a4738ff48f2f40d2a570b251a/github.go#L398
When evaluating, it comes out to:
Specifically,
getComments.Viewer.Loginreturns the name with[bot]bute.Node.Author.Loginreturns it without bot.We fixed this with an if statement checking for bots :-)
https://mondough.atlassian.net/secure/RapidBoard.jspa?rapidView=411&modal=detail&selectedIssue=INFRA-860