Merge pull request #110 from monzo/mattrco/error-fmt

Fix string format - exceptions were not being logged
monzo · Aug 20, 2019 · 6d0decb · 6d0decb
2 parents 53e29d3 + b6df8fe
commit 6d0decb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/response/slack/models/comms_channel.py b/response/slack/models/comms_channel.py
@@ -13,12 +13,14 @@
 
 class CommsChannelManager(models.Manager):
     def create_comms_channel(self, incident):
-        "Creates a comms channel in slack, and saves a reference to it in the DB"
+        """
+        Creates a comms channel in slack, and saves a reference to it in the DB
+        """
         try:
             name = f"inc-{100+incident.pk}"
             channel_id = settings.SLACK_CLIENT.get_or_create_channel(name, auto_unarchive=True)
         except SlackError as e:
-            logger.error('Failed to create comms channel {e}')
+            logger.error(f"Failed to create comms channel {e}")
 
         try:
             doc_url = urljoin(
@@ -28,7 +30,7 @@ def create_comms_channel(self, incident):
 
             settings.SLACK_CLIENT.set_channel_topic(channel_id, f"{incident.report} - {doc_url}")
         except SlackError as e:
-            logger.error('Failed to set channel topic {e}')
+            logger.error(f"Failed to set channel topic {e}")
 
         comms_channel = self.create(
             incident=incident,