Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose timeline event ID in TimelineEvent endpoint #124

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Expose timeline event ID in TimelineEvent endpoint #124

merged 4 commits into from
Sep 3, 2019

Conversation

sophiekoonin
Copy link
Contributor

@sophiekoonin sophiekoonin commented Sep 3, 2019 •
edited
Loading

So that frontends consuming this endpoint can know which ID to update!

Also, change the pk field to id so it's a bit nicer in the API.

@sophiekoonin sophiekoonin requested a review from mattrco September 3, 2019 12:43
mattrco
mattrco previously approved these changes Sep 3, 2019
View reviewed changes
@sophiekoonin sophiekoonin requested a review from mattrco September 3, 2019 13:02
mattrco
mattrco previously approved these changes Sep 3, 2019
View reviewed changes
@sophiekoonin sophiekoonin merged commit a6d55bb into master Sep 3, 2019
@sophiekoonin sophiekoonin deleted the sophiekoonin/release-0.1.2/timeline branch September 3, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrco mattrco mattrco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiekoonin @mattrco