api: return timeline event metadata as a dict type, not string #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes another regression. When we changed the JSONField, the serialization type turned to JSON rendered as a string instead of a dict. This forces the serializer to return native JSON.
ChrisAnn
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another regression. When we changed the JSONField, the
serialization type turned to JSON rendered as a string instead of a
dict. This forces the serializer to return native JSON.
I've also updated the TimelineFactory to generate more types of events - this had the effect of breaking some of the incident update tests (as they only expected a single timeline event of
incident_updateevent type to be present), so I've fixed those to retrieve the latest event.