Handle Slack API rate limiting #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a simple retry+incremental backoff for when we get rate limited by Slack (though easy to enable retries for other errors too). Given a base backoff (default 200ms) and maximum retries, we retry up to the max, backing off by the base multiplied by the number of retries. We could probably use a library to implement a more complex exponential backoff, but I think this should suffice for now. I've gone for an iterative approach over recursion to avoid stack overflows.
ChrisAnn
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a simple retry+incremental backoff for when we get rate limited
by Slack (though easy to enable retries for other errors too).
Given a base backoff (default 200ms) and maximum retries, we retry up to
the max, backing off by the base multiplied by the number of retries. We
could probably use a library to implement a more complex exponential
backoff, but I think this should suffice for now.
I've gone for an iterative approach over recursion to avoid stack
overflows.