core models: sanitize user input #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisAnn
reviewed
Sep 26, 2019
response/core/models/timeline.py
Outdated
| @@ -23,6 +24,11 @@ class TimelineEvent(models.Model): | |||
| help_text="Additional fields that can be added by other event types", null=True | |||
| ) | |||
|
|
|||
| def save(self, *args, **kwargs): | |||
| print(type(self.text)) | |||
ChrisAnn
reviewed
Sep 26, 2019
setup.py
Outdated
| @@ -8,6 +8,7 @@ | |||
| INSTALL_REQUIRES = [ | |||
| "Django>=2.2", | |||
| "bleach==3.1.0", | |||
| "bleach-whitelist>=0.0.11", | |||
There was a problem hiding this comment.
Is this a typo? I can only see 0.0.10 on pypi https://pypi.org/project/bleach-whitelist/
ChrisAnn
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the API (and Slack app) allows users to enter any text they like for various fields - this has security implications if we end up rendering that text in a UI page down the line. Django UI templating handles this case automatically, but other types of UI consuming the API won't - here we sanitize input (using https://pypi.org/project/bleach/) before it gets saved to the DB.