Limit the closing incident notification to working hours #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reminder to close an incident will happen exactly 24 hours after the incident was created which could be at a very unsociable hour. This change will ensure the reminder to close an incident only happens between 9am and 6pm.
|
Great 👍 I had to refresh my memory of how the notification handler is called - since it's every minute there won't be any missed notifications by excluding these hours. |
mattrco
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reminder to close an incident will happen exactly 24 hours after the incident was created which could be at a very unsociable hour. This change will ensure the reminder to close an incident only happens between 9am and 6pm.