-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial events API implementation #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrco
force-pushed
the
mattrco/events-api
branch
3 times, most recently
from
November 7, 2019 13:53
d793a4a
to
0cce2ab
Compare
mattrco
force-pushed
the
mattrco/events-api
branch
2 times, most recently
from
November 7, 2019 16:47
9587f1e
to
60450b4
Compare
mattrco
force-pushed
the
mattrco/events-api
branch
from
November 8, 2019 10:40
23c15a8
to
d5083d4
Compare
mattrco
commented
Nov 8, 2019
event_type = models.CharField(max_length=50) | ||
payload = models.TextField() | ||
|
||
def save(self, *args, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a getter here that parses the payload and returns a native dict, but since events are write-only this isn't currently needed.
ChrisAnn
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When incidents or actions are changed (created, updated) we generate an event log using
post_save
signals. We intend to consume these events for reporting purposes.The payload uses a
TextField
instead of JSON to maintain compatibility across database engines (and make testing easier).An API smoke test is included.
The
post_save
signals can be overridden by end users with the*_EVENT_HANDLER_CLASS
django settings - once we've tested these a bit more thoroughly they can be added to the readme.Example incident change:
Example action change: