-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the path to python #90
base: main
Are you sure you want to change the base?
Conversation
config.docker-template.php
Outdated
@@ -82,4 +82,6 @@ | |||
define('TEST_ENROL_LDAP_DOMAIN', 'ou=Users,dc=openstack,dc=org'); | |||
} | |||
|
|||
$CFG->pathtopython = 'python'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dmonllao,
should be /usr/bin/python
be more appropriate?
HTH,
Matteo
53a8862
to
915630f
Compare
Thanks for commenting Matteo. I've applied the suggested change. To be honest, I've always seen paths to binaries specified using the full path, but I have never understood what is the advantage of it over just using the file name. I do understand that the difference when the script using just the bin file name does not know the system where it will be executed, but in this case we do. |
TNX @dmonllao! HTH, |
👍 to full path |
👍 thanks for the explanation Matteo. The patch was already updated using the full path so no further changes are required. |
Any chance that we could merge this? The patch does not seem problematic. |
The failures reported by travis are unrelated to this patch. |
No description provided.