Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDLSITE-4211 testing: add ci tests to local_ci #92

Merged
merged 4 commits into from
Jul 13, 2016
Merged

MDLSITE-4211 testing: add ci tests to local_ci #92

merged 4 commits into from
Jul 13, 2016

Conversation

danpoltawski
Copy link
Contributor

@danpoltawski danpoltawski commented Jun 15, 2016 •
edited
Loading

Adds some coverage to:

  • grunt_process
  • less_checker
  • php_lint
  • shifter_walk
  • thirdparty_check

@danpoltawski danpoltawski force-pushed the MDLSITE-4211 branch 10 times, most recently from ad29330 to 9ff9e98 Compare July 13, 2016 09:05
@danpoltawski
MDLSITE-4211 add travisfile and tests structure
6eab377 
There are actually quit a few things i'm not a fan of from my first
playing with bats - one was the fact there isn't a good way to get
output from failed tests! So because of that I have also included the
bats-assert and bats-error libraries.

See https://github.com/ztombol/bats-docs for details of the assertion
lib.
@danpoltawski
MDLSITE-4211 testing: add unit tests!
3afbeeb 
* grunt_process
* less_checker
* php_lint
* shifter_walk
* thirdparty_check
@danpoltawski
Copy link
Contributor Author

Now i've sorted out the annoying travis problem, i'm sending this for integration proper

@danpoltawski
Copy link
Contributor Author

Note that I don't "love" that we have to do a whole git clone of moodle.git in the traivs job (seems slow an inefficient). But:

  • We need multiple branches, so a shallow clone is complex/tricky to achieve
  • Caching the moodle.git dir is not really much better because its a big directory and travis store it on the network anyway
  • It is surprisingly fast (1min) and we don't build that often
  • The grunt/shifter tests are are the main time sink

@stronk7 stronk7 merged commit 6c830fc into moodlehq:master Jul 13, 2016
@stronk7
Copy link
Member

stronk7 commented Jul 13, 2016

Awesome stuff!

@moodlehq moodlehq deleted a comment from Hannahmarianopigao May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danpoltawski @stronk7