Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bookworm images for php >= 81 images and make them the default ones #179

Closed
stronk7 opened this issue Aug 12, 2023 · 5 comments
Closed

Add bookworm images for php >= 81 images and make them the default ones #179

stronk7 opened this issue Aug 12, 2023 · 5 comments

Comments

@stronk7
Copy link
Member

stronk7 commented Aug 12, 2023 •
edited
Loading

Our upstream images (docker "official" ones) only support 2 debian versions for PHP version.

Recently, for php >= 81, they stopped building Debian buster images and started with Debian bookworm instead (see docker-library/php#1416). So current images look as follow:

So we need to:

  • Create bookworm variants for 8.1, 8.2 and dev.
  • Verify they work ok.
  • Make them the default ones for those branches (currently default is bullseye).

Ciao :-)
@stronk7 stronk7 changed the title Add bookworm images for php >= 81 images Add bookworm images for php >= 81 images and make them the default ones Aug 12, 2023
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 12, 2023
@stronk7
First php81 debian bookworm (12) build
19255b2 
This is related to moodlehq#179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 12, 2023
@stronk7
First php82 debian bookworm (12) build
58a6b14 
This is related to moodlehq#179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 12, 2023
@stronk7
First php83 debian bookworm (12) build
3101310 
This is related to moodlehq#179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 12, 2023
@stronk7
First php83 debian bookworm (12) build
ced1bf9 
This is related to moodlehq#179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
@stronk7
Copy link
Member Author

stronk7 commented Aug 13, 2023

Done, now the 8.1-bookworm and 8.2-bookworm tags are available @ moodle-php-apache. Also, the current dev tag (8.3beta2 right now) is built with "bookworm" (Debian 12).

Next step, put some jobs to work using those "bookworm" images before making them the default.

Ciao :-)

@stronk7
Copy link
Member Author

stronk7 commented Aug 13, 2023 •
edited
Loading

Ok, all these jobs:

Once we verify that all them are consistently passing and we make the "bookworm" the default ones, we'll need to undo the configuration changes in the jobs above.

Ciao :-)

stronk7 added a commit that referenced this issue Aug 13, 2023
@stronk7
First php83 debian bookworm (12) build
1971284 
This is related to #179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 13, 2023
@stronk7
First php83 debian bookworm (12) build
64fcd51 
This is related to moodlehq#179

For php-sqlsrv we are still using the buster apt source. This will
be investigated later, not part of this issue.
stronk7 added a commit that referenced this issue Aug 13, 2023
@stronk7
First php83 debian bookworm (12) build
057db2d 
This is related to #179

For php-sqlsrv we are still using the bullseye apt source. This will
be investigated later, not part of this issue.
@stronk7
Copy link
Member Author

stronk7 commented Aug 17, 2023

We have had the new images running over the last days (in the jobs commented above) and everything seems to be working ok with them.

So, tomorrow (17th August 2023), we'll proceed to make them the default ones for php>= 81. And buster ones will be deprecated / EOLed.

Ciao :-)

stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Stop using the bullseye version as default for php81
f3ba5e2 
We are moving to bookworm (Debian 12) as new default, while
out-dating the buster one. See, for more information:

moodlehq#179
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Stop using the bullseye version as default for php82
30dc9a4 
We are moving to bookworm (Debian 12) as new default, while
out-dating the buster one. See, for more information:

moodlehq#179
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Make bookworm the new default for php82 images
b33cefe 
Part of moodlehq#179
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Make bookworm the new default for php81 images
ab05780 
Part of moodlehq#179
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Make bookwork the default images for php81 and php82
d231d3b 
And "deprecate" the buster ones for those PHP versions. Part of moodlehq#179.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Remove automated builds from the php81 buster image
4152dd6 
Upstream images aren't built anymore (they have deprecated
buster and added bookworm), so we don't need to coninuously
be checking php81 versions any more. Part of moodlehq#179
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Remove automated builds from the php82 buster image
25aaec0 
Upstream images aren't built anymore (they have deprecated
buster and added bookworm), so we don't need to coninuously
be checking php82 versions any more. Part of moodlehq#179
@stronk7
Copy link
Member Author

stronk7 commented Aug 18, 2023 •
edited
Loading

Ok, now all the pieces should be in place:

  1. 8.1-bookworm and 8.2-bookworm are now the defaults for 8.1 and 8.2 (and bullseye aren't any more).
  2. 8.1-buster and 8.2-buster are now sort of "deprecated", not being automatically built anymore (sticky to 8.1.20 and 8.2.7).
  3. README in master has been adjusted to show all the above.

Ciao :-)

PS: The images are being rebuilt while writing this comment, so the changes will come into effect in some hours.

stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Remove automated builds from the php81 buster image
961ca59 
Upstream images aren't built anymore (they have deprecated
buster and added bookworm), so we don't need to coninuously
be checking php81 versions any more. Part of moodlehq#179

Also, update its README to show it's not being updated.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Remove automated builds from the php82 buster image
b253e63 
Upstream images aren't built anymore (they have deprecated
buster and added bookworm), so we don't need to coninuously
be checking php82 versions any more. Part of moodlehq#179

Also, update its README to show it's not being updated.
stronk7 added a commit to stronk7/moodle-php-apache that referenced this issue Aug 18, 2023
@stronk7
Make bookwork the default images for php81 and php82
24d8e10 
And "deprecate" the buster ones for those PHP versions. Part of moodlehq#179.
@stronk7
Copy link
Member Author

stronk7 commented Aug 18, 2023

Done, all the new images and defaults seem to be already in place:

And CIs will start using the new bookworm defaults starting now.

So, closing this as done, ciao :-)

@stronk7 stronk7 closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stronk7