-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One branch to rule them all #169
base: main
Are you sure you want to change the base?
Conversation
1062730
to
eb6a16e
Compare
b2c975a
to
ae49f19
Compare
ae49f19
to
049b0e2
Compare
This is working more-or-less as I was hoping for and it will greatly simplify our workflow. One PR can now target all relevant images. There is a little duplication in that each file is a copy of the previous branch, but that's true of a multi-branch approach (and harder to compare the files too). We could possibly create a wrapper and generator, which is what I originally tried to do in #44, but really... we have 6-12 images total at any one time, and they differ in ways that make it quite hard to reduce that duplication without a whole heap of boilerplate. |
Ah, the only thing that I don't have solved is badges for the README.md. GHA badges only work on a once-per-workflow basis, and do not generate one per matrix combination. |
Oh, and the push is currently not setting the right value for the pushed image name. |
Side comment: I must confess I'm not entirely convinced about the benefits of this change. I've been thinking about it (move everything to a single branch) for some long time, and always end with the conclusion about separate branches being better. It's super easy to backport anything, everything is fully separated, in case there are tiny lib differences / details... each branch its image, push and build individually... and with the all-in-one we lose many of those benefits. Just IMO, ciao :-) |
Hi, what do you think if we close this? I've just backported #173 (for example) to all branches >= 7.4 and really it's super easy (easier than having everything in the same branch, honestly). Ciao :-) |
64fcd51
to
057db2d
Compare
This PR is an attempt to have on e branch which contains all versions and all codebases. Although this does lead to duplicate code, it may be easier to maintain.
Pushing as a test to see how it plays out at the moment.