Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the mongodb extension for 7.2 #61

Merged
merged 1 commit into from
May 27, 2019

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 26, 2019

Just that, nothing else needs to be done. moolde-docker will have
other changes to make the test environment ready.

This is part of #16

Unit tests are passing ok with 37_STABLE and master:

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit --testsuite cachestore_mongodb_testsuite -v
Moodle 3.7+ (Build: 20190524), e39f3b7db215b61d68ea2a23ff850f0efa1853e8
Php: 7.2.18, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 7.5.9 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.2.18
Configuration: /var/www/html/phpunit.xml

..                                                                  2 / 2 (100%)

Time: 4 seconds, Memory: 52.00 MB

OK (2 tests, 42 assertions)

And being skipped with previous Moodle versions (where MDL-54592) was not implemented:

$ bin/moodle-docker-compose exec webserver vendor/bin/phpunit --testsuite cachestore_mongodb_testsuite -v
Moodle 3.6.4+ (Build: 20190524), baebbcc341e44dc5552d54a2be8c6fdd3cf4d9c8
Php: 7.3.5, pgsql: 9.6.7, OS: Linux 4.9.125-linuxkit x86_64
PHPUnit 6.5.8 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.3.5
Configuration: /var/www/html/phpunit.xml

SS                                                                  2 / 2 (100%)

Time: 4.45 seconds, Memory: 48.00MB

There were 2 skipped tests:

1) cachestore_mongodb_test::test_collection_name
Could not test cachestore_mongodb. Requirements are not met.

/var/www/html/cache/tests/fixtures/stores.php:52
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit -v "cachestore_mongodb_test" cache/stores/mongodb/tests/mongodb_test.php

2) cachestore_mongodb_test::test_test_instance
Could not test cachestore_mongodb. Requirements are not met.

/var/www/html/cache/tests/fixtures/stores.php:52
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit -v "cachestore_mongodb_test" cache/stores/mongodb/tests/mongodb_test.php

OK, but incomplete, skipped, or risky tests!
Tests: 2, Assertions: 0, Skipped: 2.

Just that, nothing else needs to be done. moolde-docker will have
other changes to make the test environment ready.
@andrewnicols andrewnicols merged commit 9d33e2b into moodlehq:7.2-stretch May 27, 2019
@stronk7 stronk7 deleted the mongodb72 branch May 27, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants