Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump php-cs-fixer to v2.19.0 #95

Merged
merged 1 commit into from
May 10, 2021

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 8, 2021

That version supports PHP8 and is the last one
before jumping to v3 that comes with huge changes.

This will help in the progress towards PHP8 support happening @ #94

@stronk7
Copy link
Member Author

stronk7 commented May 8, 2021

And it works ok with PHP8 too, just in case (apart from current CI tests using it):

$ make
php build/php-cs-fixer.phar fix -v || true
PHP CS Fixer 2.19.0 Testament by Fabien Potencier and Dariusz Ruminski (d5b8a9d)
Runtime: PHP 8.0.3
Loaded config default from "/Users/stronk7/git_moodle/moodle-plugin-ci/.php-cs-fixer.php".
.........................................................................................................................................
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error

Fixed all files in 3.147 seconds, 14.000 MB memory used

@stronk7 stronk7 force-pushed the php-cs-fixer-bump-219 branch from 81472fa to 6299b3b Compare May 8, 2021 22:00
@stronk7
Copy link
Member Author

stronk7 commented May 8, 2021

Aha, there is a new rule no_alias_language_construct_call in the Symfony rules. I think it's ok to keep it enabled, so fixing the die()uses.

That version supports PHP8 and is the last one
before jumping to v3 that comes with huge changes.

Fixes moodlehq#17
@stronk7 stronk7 force-pushed the php-cs-fixer-bump-219 branch from 6299b3b to b618c4d Compare May 9, 2021 15:35
Copy link
Member

@kabalin kabalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks @stronk7

@kabalin kabalin merged commit 25dc417 into moodlehq:master May 10, 2021
@stronk7
Copy link
Member Author

stronk7 commented May 10, 2021

Thanks!

@stronk7 stronk7 deleted the php-cs-fixer-bump-219 branch May 10, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants