Update project dependencies #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most noticeble one being local_moodlecheck v1.0.7 that comes with PHP8 specific fixes. Also updated nikic/php-parser to newer version, able to run with any >= 7.0 PHP version (8.0 included) and parse every PHP version (5.x to 8.0). Changes to the php-parser required some changes in code: - Look for assignments inside extra Expression element. - Add 3 psalm cases to baseline, about some casts (the objects have the _toString() method, but psalm isn't aware). (details @ https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-4.0.md) Finally, so changes because of phpmd bump were also required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most noticeble one being local_moodlecheck v1.0.7 that
comes with PHP8 specific fixes.
Also updated nikic/php-parser to newer version, able
to run with any >= 7.0 PHP version (8.0 included) and
parse every PHP version (5.x to 8.0).
Changes to the php-parser required some changes in code:
objects have the _toString() method, but psalm isn't
aware).
(details @ https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-4.0.md)
Finally, some changes because of phpmd bump were also required.