Fail explicitly when MAS creation fails.

moolitayer · Jul 6, 2017 · 01626ae · 01626ae
1 parent ed6f7be
commit 01626ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/models/miq_alert.rb b/app/models/miq_alert.rb
@@ -225,7 +225,7 @@ def add_status_post_evaluate(target, result, event)
     status.event_ems_ref = ems_ref unless ems_ref.blank?
     status.resolved = resolved
     status.evaluated_on = Time.now.utc
-    status.save
+    status.save!
     miq_alert_statuses << status
   end
 

diff --git a/spec/models/miq_alert_spec.rb b/spec/models/miq_alert_spec.rb
@@ -190,6 +190,15 @@
         expect(mas.severity).to eq(nil)
       end
 
+      it "raises an exception when miq_alert_status creation fails" do
+        expect do
+          @alert.evaluate(
+            [@vm.class.base_class.name, @vm.id],
+            :ems_event => FactoryGirl.create(:ems_event, :full_data => {:severity => 'undefined'})
+          )
+        end.to raise_error(ActiveRecord::RecordInvalid)
+      end
+
       it "miq_alert_status.url = ems_event.full_data.url if present" do
         @alert.evaluate(
           [@vm.class.base_class.name, @vm.id],