Support Loading Ligature & Substitution Glyphs #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant issue: #127? |
|
Sorry for the delay, this is great. Can we swap it to being a flag on FontSettings and I'll merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional (off by default) feature that loads the glyphs for ligatures & substitutions.
This makes it so that glyphs that have been shaped by some other crate (allsorts, rustybuzz) to actually render if they formed a ligature or substitution.
Using the allsorts crate to shape Cascadia Code with ligatures:
Example without ligature loading (note that the ligatures, after being shaped, do not get rendered):
Example with: