Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hashbrown optional #153

Merged
merged 1 commit into from
May 13, 2024
Merged

Make hashbrown optional #153

merged 1 commit into from
May 13, 2024

Conversation

not-fl3
Copy link
Contributor

@not-fl3 not-fl3 commented May 13, 2024

hashbrown became a fairly heavy dependency:

├── fontdue v0.7.3
│   ├── hashbrown v0.13.2
│   │   └── ahash v0.8.11
│   │       ├── cfg-if v1.0.0
│   │       ├── once_cell v1.19.0
│   │       └── zerocopy v0.7.34
│   │           └── zerocopy-derive v0.7.34 (proc-macro)
│   │               ├── proc-macro2 v1.0.82
│   │               │   └── unicode-ident v1.0.12
│   │               ├── quote v1.0.36
│   │               │   └── proc-macro2 v1.0.82
│   │               │       └── unicode-ident v1.0.12
│   │               └── syn v2.0.63
│   │                   ├── proc-macro2 v1.0.82
│   │                   │   └── unicode-ident v1.0.12
│   │                   ├── quote v1.0.36
│   │                   │   └── proc-macro2 v1.0.82
│   │                   │       └── unicode-ident v1.0.12
│   │                   └── unicode-ident v1.0.12
│   │       [build-dependencies]
│   │       └── version_check v0.9.4
│   └── ttf-parser v0.15.2

hashbrown had the same problem in the past: tkaitchuck/aHash#18), I believe it might be fixed again (I should do a PR there too!).

But so far - it would be nice to just fallback to std.

@mooman219
Copy link
Owner

ah yeah that's unfortunate, sounds good to make it optional

@mooman219 mooman219 merged commit c86ce94 into mooman219:master May 13, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants