Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethers Updates for Tutorials #806

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Ethers Updates for Tutorials #806

merged 8 commits into from
Dec 8, 2023

Conversation

themacexpert
Copy link
Contributor

@themacexpert themacexpert commented Dec 6, 2023

Description

A couple of our tutorials needed a bit of refreshing on Ethers and related items.

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If pages have been moved around, I have created an additional PR in moonbeam-mkdocs to update redirects
  • If pages have been moved around, I have run the move-pages.py script to move the pages and update the image paths on the chinese repo
    • After the script has been run, I have created an additional PR in moonbeam-docs-cn
  • If images have been added, I have run the compress-images.py script to compress the images.
  • If variables (in variables.yml) need to be updated (such as a name change), I have updated the moonbeam-docs-cn repo to use the new variables
  • If this page requires a disclaimer, I have added one

Corresponding PRs

Please link to any corresponding PRs here.

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@themacexpert themacexpert added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Dec 6, 2023
@themacexpert themacexpert requested a review from eshaben December 6, 2023 06:38
Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! 🙌

tutorials/eth-api/batch-approve-swap.md Show resolved Hide resolved
tutorials/eth-api/batch-approve-swap.md Show resolved Hide resolved
tutorials/eth-api/how-to-build-a-dapp.md Show resolved Hide resolved
tutorials/eth-api/randomness-lottery.md Show resolved Hide resolved
tutorials/eth-api/how-to-build-a-dapp.md Show resolved Hide resolved
@themacexpert themacexpert requested a review from eshaben December 8, 2023 00:16
Comment on lines +59 to +73
In the `Randomness.sol` file, you can paste in the Randomness Precompile contract.

??? code "Randomness.sol"

```solidity
--8<-- 'code/builders/pallets-precompiles/precompiles/randomness/Randomness.sol'
```

Similarly, in the `RandomnessConsumer.sol` file, you can paste in the Randomness Consumer contract.

??? code "RandomnessConsumer.sol"

```solidity
--8<-- 'code/builders/pallets-precompiles/precompiles/randomness/RandomnessConsumer.sol'
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YASSS! thank you! 🙌

Copy link
Contributor

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eshaben eshaben merged commit 7fa07d9 into master Dec 8, 2023
1 check passed
@eshaben eshaben deleted the themacexpert/hardhatUpdates branch December 8, 2023 06:21
wuzhong-papermoon added a commit to moonbeam-foundation/moonbeam-docs-cn that referenced this pull request Jan 29, 2024
Original PR:
moonbeam-foundation/moonbeam-docs#806

Most of the updates has already been applied in the CN docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants