Feature/add more polkadot js types #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joelamouche
commented
Nov 10, 2020
joelamouche
commented
- update polkadot-js types
- add rpc method declarations from Frontier
crystalin
reviewed
Nov 12, 2020
|
ready to merge @crystalin |
crystalin
reviewed
Nov 16, 2020
|
NB: there is no way to make a string fir on multiple lines in json so I removed the line length contraint on json files |
JoshOrndorff
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Prettier is complaining about files not changed in this PR. That CI is way more touchy that I expected.
I'm fine merging this if @joelamouche is ready
|
Oh I just ran the linter on those files. Should I revert? |
joelamouche
force-pushed
the
feature/add-more-polkadot-js-types
branch
from
96cf953
to
6d51efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.