Moonbeam Phase 2 - Remove call filter #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
the
B7-runtimenoteworthy
librelois
requested changes
Dec 14, 2021
|
With this PR, we can uncomment the skipped crowdloan-rewards tests |
librelois
approved these changes
Dec 16, 2021
crystalin
approved these changes
Dec 17, 2021
| @@ -774,7 +775,7 @@ fn claim_via_precompile() { | |||
|
|
|||
| // Alice uses the crowdloan precompile to claim through the EVM | |||
| let gas_limit = 100000u64; | |||
| let gas_price: U256 = 1_000_000_000.into(); | |||
| let gas_price: U256 = 100_000_000_000u64.into(); | |||
There was a problem hiding this comment.
https://github.com/PureStake/moonbeam/blob/jeremy-moonbeam-phase-2-filter/runtime/moonbeam/src/lib.rs#L346
Minimum gas price is 1 GWei * SUPPLY_FACTOR (100)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Allow all calls for Phase 2.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?