Automate the test specs generation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think this is a step better, but I think a much bigger step would be to stop generating a json test spec entirely. That json file is just one more thing to get accidentally out of sync as we have seen. Why not use the spec that is stored in the chain_spec.rs file?
|
@JoshOrndorff |
crystalin
pushed a commit
that referenced
this pull request
Jun 18, 2021
crystalin
added a commit
that referenced
this pull request
Jul 20, 2021
* Drafting parachain tests * Improvements, needs polkadot-launch pr #113 * Adds parachain tests to the CI * Type in CI build * Fix missing requirement in para test CI * Removes extra useless build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the specs for the test in profit of the template.
The
npm run testcommand is now generating the specs from the template and running the tests after.2 new commands have been added:
npm run generate-specswhich generates the specsnpm run test-onlywhich runs the test without generating the specs.In addition, the test are now by default using the Release Binary. To use the debug binary:
BINARY_PATH=../node/standalone/target/debug/moonbase-standalone npm run test