Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Girazoki support both pre and post 0.9.16 anchoring logics for native token 0.9.16 #1274

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Feb 9, 2022

What does it do?

Brings #1232 to 0.9.16

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@crystalin
Copy link
Collaborator

sp_runtime::traits::AccountIdConversion::into_account seems to break with the PALLET_ID in rust tests

Also PalletAssetsAssetBalance is now PalletAssetsAssetAccount however the tests are not passing

@girazoki can you fix the test and merge please ?

@crystalin crystalin added A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Feb 9, 2022
@librelois librelois mentioned this pull request Feb 10, 2022
13 tasks
@girazoki
Copy link
Collaborator Author

yep on it

@girazoki
Copy link
Collaborator Author

Gonna merge this branch as I verified the xcm tests pass. Anything left to do in the tests we will make it in the base branch (although I fixed some here)

@girazoki girazoki merged commit b1e10cb into jeremy-polkadot-v0.9.16 Feb 10, 2022
@girazoki girazoki deleted the girazoki-support-both-pre-and-post-0.9.16-anchoring-logics-for-native-token-0.9.16 branch February 10, 2022 11:21
crystalin pushed a commit that referenced this pull request Feb 10, 2022
* Update deps (wip)

* fix AccountId default errors but still need MaxEncodedLen derivation

* cleanup staking changes + without_storage_info

* update runtimes (TODO: AllPallets changes)

* use AllPalletsReversedWithSystemFirst to keep current behavior

* fmt

* Update client

* Update Rust tests

* fmt

* Set custom deadline percent

* Rename specs in dockerfile

* Improve indentation

* Remove extra whitespaces

* closure fmt

* fmt

* Girazoki support both pre and post 0.9.16 anchoring logics for native token 0.9.16 (#1274)

* Add dual support in moonbase

* Add tests for proving both representations are handled

* Typescript tests for reanchoring

* Cleaning and documenting

* More docu

* fix docu of teleports

* EditorConfig

* more editorconfig

* Fix compilation error after cleanup

* clean more

* Toml sort

* Modify tests to make them pass

* pallet-identity to std and fix integration tests pallet maintenance mode

* Fix crowdloan-rewards precompile tests by using H160

* FMT

* Toml sort

* Comment another assertion of a missing event in xtokens

* fix benchmark build

* Update tests to fix the new assetBalance type

* Fix dmp and hrmp

* ts prettier

* Fix hopefully last test

* Last last last test

* fix para tests config

* Update frontier

* Temporarily hardcode parameter runtime_cache_size

* Revert "Temporarily hardcode parameter runtime_cache_size"

This reverts commit d9cb8ea.

* update substrate

Co-authored-by: 4meta5 <asinghchrony@protonmail.com>
Co-authored-by: tgmichel <telmo@purestake.com>
Co-authored-by: Crystalin <alan@purestake.com>
Co-authored-by: girazoki <gorka.irazoki@gmail.com>
Co-authored-by: librelois <c@elo.tf>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8-mergeoncegreen Pull request is reviewed well. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants