Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the api to verify the web3.clientVersion test #156

Merged
merged 1 commit into from
Jan 5, 2021
Merged

use the api to verify the web3.clientVersion test #156

merged 1 commit into from
Jan 5, 2021

Conversation

joelamouche
Copy link
Contributor

What does it do?

use the api to verify the web3.clientVersion test, instead of using a hardcoded specName and a regexp version

Checklist

  • Does it require a purge of the network?
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ?

JoshOrndorff
JoshOrndorff approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@JoshOrndorff JoshOrndorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good idea.

@joelamouche joelamouche merged commit ae8c28e into master Jan 5, 2021
@joelamouche joelamouche deleted the antoine-use-api-spec-in-test branch January 5, 2021 14:57
@JoshOrndorff JoshOrndorff mentioned this pull request Jan 7, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshOrndorff JoshOrndorff JoshOrndorff approved these changes

@crystalin crystalin Awaiting requested review from crystalin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelamouche @JoshOrndorff