Return to standard Alice and Bob accounts #158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I probably introduced this old file during a botched merge conflict.
crystalin
approved these changes
Jan 4, 2021
| @@ -49,11 +68,16 @@ pub fn get_chain_spec(para_id: ParaId) -> ChainSpec { | |||
| ChainSpec::from_genesis( | |||
| "Moonbase Parachain Local Testnet", | |||
| "local_testnet", | |||
| ChainType::Local, | |||
| ChainType::Development, | |||
There was a problem hiding this comment.
My previous understanding was that this would give Apps a clue to include Alice, Bob, etc in the interface. It did not work, so I need to dig more into it.
|
Superseded by #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Modifies the built-in chain specifications to use the Substrate-standard
//Aliceand//Bobaccounts in most places. In particular Alice is now the Sudo key and both Alice and Bob are funded at genesis. Even after this PR the Gerald account is still funded at genesis since external tools probably depend on it. It also changes the chain type toDevelopmentso that Apps will automatically include the dev accounts.What important points reviewers should know?
These Alice and Bob accounts are used in the Substrate node template and throughout the Substrate ecosystem. They are derived from the dev phrase.
What value does it bring to the blockchain users?
This change allows developers of Moonbeam and of dApps that run on moonbeam to launch and interact with a simple testnet with fewer hurdles to jump through.
TODO: Wrong addresses
Alice's address as generated by the node after this PR does not match the one generated by Apps. So something needs to be sorted out there.
Checklist