Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasmtime to both nodes #160

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add wasmtime to both nodes #160

merged 1 commit into from
Jan 5, 2021

Conversation

JoshOrndorff
Copy link
Contributor

What does it do?

Enables executing the compiled wasm runtime using wasmtime in both the parachain and standalone node.

What important points reviewers should know?

This feature was already enabled in the parachain node, but not on purpose. It had been enabled directly in the Cargo.lock file (probably by me copying from cumulus repo), but it hadn't been enabled in Cargo.toml. So that's why there are no changes to the parachain node's Cargo.lock file in this PR.

Checklist

  • Does it require a purge of the network?
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ?

notlesh
notlesh approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@notlesh notlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joshy!

@JoshOrndorff JoshOrndorff added A8-mergeoncegreen Pull request is reviewed well. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority". labels Jan 5, 2021
@JoshOrndorff JoshOrndorff merged commit 74e120b into master Jan 5, 2021
@JoshOrndorff JoshOrndorff deleted the stop-wasmtime branch January 5, 2021 20:29
@crystalin
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlesh notlesh notlesh approved these changes

@crystalin crystalin crystalin approved these changes

Assignees
No one assigned
Labels
A8-mergeoncegreen Pull request is reviewed well. B0-silent Changes should not be mentioned in any release notes C1-low Does not elevate a release containing this beyond "low priority".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshOrndorff @crystalin @notlesh