Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick Frontier 892 and 898 #1974

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Nov 28, 2022

What does it do?

Cherry-picks two Frontier client-related PRs into our moonbeam-polkadot-v0.9.32 Frontier branch:

polkadot-evm/frontier#892
polkadot-evm/frontier#898

@notlesh notlesh requested review from girazoki and tgmichel November 28, 2022 22:43
@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Nov 28, 2022
@tgmichel
Copy link
Contributor

lgtm but I suggest we modify our test-eth-fee-history.ts test like upstream,

from:

expect(result.gasUsedRatio.length).to.be.eq(block_count);

to:

expect(result.gasUsedRatio).to.be.deep.eq(Array(block_count).fill(0.03575712));

@notlesh
Copy link
Contributor Author

notlesh commented Nov 29, 2022

expect(result.gasUsedRatio).to.be.deep.eq(Array(block_count).fill(0.03575712));

I implemented this, but changed the expectation from 0.03575712 to 0.0291662. I also observed the race condition in this test again, so I'm not sure what to think :) Please double-check for me.

@notlesh notlesh requested a review from tgmichel November 29, 2022 17:51
Copy link
Contributor

@tgmichel tgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also observed the race condition in this test again

Yeah.. I can only think of what we talked in the past regarding this, which is requesting the fee history data "too early" (the background task didn't yet updated the Mutex).

@notlesh notlesh merged commit 21b67a2 into master Nov 30, 2022
@notlesh notlesh deleted the notlesh-frontier-client-fixes-2022-11-28 branch November 30, 2022 15:41
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
* Bump frontier from 69e7c5b to 1f715c5

* Check gasUsedRatio against array fill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants