Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record log cost first in collective precompile #2086

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

tgmichel
Copy link
Contributor

@tgmichel tgmichel commented Feb 9, 2023

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tgmichel tgmichel added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Feb 9, 2023
@tgmichel tgmichel requested a review from 4meta5 February 9, 2023 16:54
@tgmichel tgmichel merged commit 677b89c into master Feb 10, 2023
@tgmichel tgmichel deleted the tgm-collective-precompile-logs-fix branch February 10, 2023 08:32
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
…#2086)

* Record log cost first in `collective` precompile

* Fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants