-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Substrate/Polkadot/Cumulus/Frontier dependency to 0.9.38 #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml
tgmichel
added
A0-pleasereview
Pull request needs code review.
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
A10-evmtracing
Pull request includes evm tracing functionality
breaking
Needs to be mentioned in breaking changes
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
labels
Mar 13, 2023
notlesh
reviewed
Mar 23, 2023
notlesh
reviewed
Mar 23, 2023
20 tasks
girazoki
reviewed
Mar 24, 2023
girazoki
reviewed
Mar 24, 2023
girazoki
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see anything to pick on except the migration of RemoteTransactionInfoWithWeightLimit
. We need to migrate the XcmV2Weight to weight as well, putting DEFAULT_PROOF_SIZE
This reverts commit 65e723c.
girazoki
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crystalin
changed the title
Update 0.9.38
Update Substrate/Polkadot/Cumulus/Frontier dependency to 0.9.38
Apr 13, 2023
notlesh
added
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
and removed
D9-needsaudit👮
PR contains changes to fund-managing logic that should be properly reviewed and externally audited
labels
Apr 26, 2023
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* Init * update precompile xcm utils * update precompile xcm utils tests * update `pallet-erc20-xcm-bridge` * update `pallet-erc20-xcm-bridge` tests * update `xcm-primitives` * update `xcm-primitives` tests * update `pallet-xcm-transactor` + tests * update `moonbeam-xcm-benchmarks` + tests * update `pallet-evm-precompile-xtokens` + tests * update `pallet-evm-precompile-xcm-transactor` + tests * update `pallet-evm-precompile-xcm-utils` + tests * update `moonbase-runtime` + tests * cleanup * update `moonriver-runtime` + tests * update `moonbeam-runtime` + tests * update `moonbeam-rpc-debug` and `moonbeam-rpc-trace` * update `moonbeam-service` * some additional fixes, cargo check green * cleanup warnings * fmt * remove `XcmExecutorWrapper` * editorconfig * Update polkadot pin * Fix test build * Update `DEFAULT_PROOF_SIZE` in preocmpiles * Update `pallet-evm-precompileset-assets-erc20` test weights * Update `transact_through_signed_precompile_works_v1` test weight * update `RemoveItemsLimit` * wip fix ts tests * update `RemoveItemsLimit` 2 * wip update benchmarks * remove comment * update benchmarks * update `manual-xcm-rpc` * fix remaining dep version updates * wip fix ts tests * remove `XcmExecuteFilterWrapper` * comment on destroy accounts magic number * use `DEFAULT_PROOF_SIZE` const * comment on TODO handle proof size payment * fix `test-mock-hrmp-queue` * repin orml * repin cumulus * fix `test-mock-dmp-queue` test * wip `pallet-asset-manager` migration * `pallet-asset-manager` migration tests * wip `pallet-xcm-transactor` migration * `pallet-xcm-transactor` migration tests * fmt * toml-sort * editorconfig * remove unused * prettier * missing import * repin polkadot * migrate `RemoteTransactInfoWithMaxWeight` * set 0.75 `MAX_POV_SIZE` moonbase only * `pallet-asset-manager` fix pre and post upgrade tests * `pallet-xcm-transactor` fix pre and post upgrade tests * fmt * repin substrate * Revert "set 0.75 `MAX_POV_SIZE` moonbase only" This reverts commit 65e723c. * add defensive `transact_required_weight_at_most` value * Increase `DEFAULT_PROOF_SIZE` to 128kb * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0-pleasereview
Pull request needs code review.
A10-evmtracing
Pull request includes evm tracing functionality
B7-runtimenoteworthy
Changes should be noted in any runtime-upgrade release notes
breaking
Needs to be mentioned in breaking changes
D1-audited👍
PR contains changes to fund-managing logic that has been properly reviewed and externally audited
D1-runtime-migration
PR introduces code that might require downstream chains to run a runtime upgrade.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
0.9.38 dependency upgrade. Updates Moonbeam to add XcmV3 support.
Api changes and migrations
pallet-asset-manager
AssetIdType
,AssetTypeId
,AssetTypeUnitsPerSecond
,SupportedFeePaymentAssets
storage items are being migrated to XcmV3 MultiLocation.register_foreign_asset
set_asset_units_per_second
change_existing_asset_type
remove_supported_asset
pallet-xcm-transactor
TransactInfoWithWeightLimit
,DestinationAssetFeePerSecond
storage items are being migrated to XcmV3 MultiLocation.Config
'sLocationInverter
associated type is removed.Config
'sUniversalLocation
associated type is added.Weight
V2.ErrorSending
event is replaced byErrorDelivering
at the same index (10).ErrorValidating
at last index (25).Weight
V2 as input break public Api:transact_through_derivative
transact_through_sovereign
set_transact_info
remove_transact_info
transact_through_signed
set_fee_per_second
remove_fee_per_second
hrmp_manage
What important points reviewers should know?
Transact
instruction does not properly account for proof size Weight. To temporarily solve this, polkadot adds aSafeCallFilter
, which are calls that are whitelisted inTransact
. This calls typically have a fixedWeight
, does not contain nested calls, have a defined proof size.. The implementation ofSafeCallFilter
in Moonbeam is, at the time of writting, TODO, as we need to decide what to do with theEthereumXcm
. What do we do?Is there something left for follow-up PRs?
moonbeam-xcm-benchmarks
. New required functions are added astodo!
in this PR.What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
Upstream bugs have been found in the process of this update. They are either fixed or actively being fixed currently and properly backported to 0.9.38 release branches:
What value does it bring to the blockchain users?