Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GeneralAdmin track to change Council/TC members #2195

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Allow GeneralAdmin track to change Council/TC members #2195

merged 3 commits into from
Apr 4, 2023

Conversation

tgmichel
Copy link
Contributor

What does it do?

Backports paritytech/substrate#13159 to our 0.9.38 branches and allows GeneralAdmin (and Root) origins to call pallet_collective::set_members in moonbase and moonriver.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@tgmichel tgmichel added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Mar 30, 2023
@tgmichel tgmichel added the not-breaking Does not need to be mentioned in breaking changes label Mar 30, 2023
@librelois librelois merged commit 3949289 into master Apr 4, 2023
@librelois librelois deleted the tgm-generaladmin branch April 4, 2023 20:11
@crystalin crystalin changed the title add GeneralAdminOrRoot to SetMembersOrigin Allow GeneralAdmin track to change Council/TC members Apr 13, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Apr 26, 2023
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@tgmichel @imstar15
add GeneralAdminOrRoot to SetMembersOrigin (moonbeam-foundation#2195
6dcd5f7 
)

* add `GeneralAdminOrRoot` to `SetMembersOrigin`

* repin polkadot

* repin polkadot..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

@librelois librelois librelois approved these changes

@crystalin crystalin Awaiting requested review from crystalin

@girazoki girazoki Awaiting requested review from girazoki

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tgmichel @librelois @4meta5 @notlesh