Make XCM fee handler implementation more compliant with MultiAsset non-zero amounts #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librelois
added
B7-runtimenoteworthy
librelois
added
the
not-breaking
|
Is there any way to combine this into the build features previous step and add a dependency; or do we need to have both distinct steps? |
nbaztec
approved these changes
May 3, 2023
No we can't merge build and test build, it's very different |
crystalin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Enable debug-assertions and overflow-checks in rust tests with a new dedicated rust profile, like polkadot does: https://github.com/paritytech/polkadot/blob/master/Cargo.toml#L198-L202
Adapt our XCM fee handler implementation to comply with the assumption that a MultiAsset can't have a zeroed amount (fix XCM primitives tests fails on test profile #2268)