add a smoke test to verify fix for the invalid parent hash in moonbase #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
added
B0-silent
timbrinded
reviewed
May 9, 2023
timbrinded
reviewed
May 9, 2023
timbrinded
approved these changes
May 9, 2023
|
Coverage generated "Thu May 11 15:56:26 UTC 2023": Master coverage: N/A |
|
Can we merge it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
add a smoke test to verify fix for the invalid parent hash in moonbase
What important points reviewers should know?
This is related to the bug introduced in polkadot-evm/frontier#570 which we have been fixing via cherry-picking moonbeam-foundation/frontier#37 and now it is set to be mediated as the upstream PR polkadot-evm/frontier#1044