Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staking inflation #232

Merged
merged 25 commits into from
Feb 9, 2021
Merged

staking inflation #232

merged 25 commits into from
Feb 9, 2021

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Feb 5, 2021 •
edited
Loading

What does it do?

Enforces an annual inflation rate range by converting it to a per-round inflation range to compute the issuance range and calculate issuance according to how total staked compares with staking expectations.

What important points reviewers should know?

high-level docs

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

#179

What value does it bring to the blockchain users?

Checklist

  • Does it require a purge of the network? no
  • You bumped the runtime version if there are breaking changes in the runtime ?
  • Does it require changes in documentation/tutorials ? no

JoshOrndorff
JoshOrndorff reviewed Feb 5, 2021
View reviewed changes
pallets/stake/src/lib.rs Outdated Show resolved Hide resolved
pallets/stake/src/lib.rs Show resolved Hide resolved
pallets/stake/src/lib.rs Outdated Show resolved Hide resolved
pallets/stake/src/lib.rs Outdated Show resolved Hide resolved
@4meta5 4meta5 marked this pull request as ready for review February 8, 2021 10:39
@4meta5 4meta5 added A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Feb 8, 2021
4meta5
4meta5 commented Feb 8, 2021
View reviewed changes
tests/tests/test-stake.ts Outdated Show resolved Hide resolved
crystalin
crystalin reviewed Feb 8, 2021
View reviewed changes
runtime/src/lib.rs Outdated Show resolved Hide resolved
@crystalin crystalin merged commit 6573a0c into master Feb 9, 2021
@crystalin crystalin deleted the amar-inflation branch February 9, 2021 01:58
@4meta5 4meta5 mentioned this pull request Feb 9, 2021
Closed
@sea212 sea212 mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crystalin crystalin crystalin left review comments

@JoshOrndorff JoshOrndorff JoshOrndorff left review comments

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4meta5 @crystalin @JoshOrndorff