Deprecate delegate in sol

[nbaztec]

What does it do?

deprecate delegate in solidity contract

⚠️ Breaking Changes ⚠️

❗ Deprecate delegate

Deprecates the delegate call in favor of delegateWithAutoCompound in the precompile.

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

[github-actions]

Coverage generated "Mon Jun 26 15:41:24 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2333/html/index.html

Master coverage: 70.94%
Pull coverage: 70.94%

[notlesh]

We could be more verbose and explain that we intend to remove this in the future, maybe also that it's more expensive (is that true?)

[nbaztec]

Yes it is more expensive, and this method is a superset of delegate. I'll add that

[notlesh]

I would make sure the whitespace changes are needed, but otherwise looks good

[nbaztec]

I would make sure the whitespace changes are needed, but otherwise looks good

@notlesh I was also surprised about it. Turns out that it was me who originally committed that file using the autoformat via the solidity extension suggested by Alan, seems that the same extension now formats things differently.