Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes PoV gas Computation to ignore other transactions (frontier) #2343

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

tgmichel
Copy link
Contributor

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@github-actions
Copy link
Contributor

Coverage generated "Mon Jun 12 09:50:27 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2343/html/index.html

Master coverage: 71.22%
Pull coverage: 71.22%

@tgmichel tgmichel added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 13, 2023
@tgmichel tgmichel marked this pull request as ready for review June 13, 2023 08:06
@tgmichel tgmichel added the breaking Needs to be mentioned in breaking changes label Jun 13, 2023
@crystalin crystalin merged commit 946ee85 into master Jun 13, 2023
@crystalin crystalin deleted the tgm-pin-frontier-c6f66e4 branch June 13, 2023 09:13
@crystalin crystalin mentioned this pull request Jun 8, 2023
24 tasks
@crystalin crystalin changed the title scope of already recorded codes and storages must be per transaction Changes PoV gas Computation to ignore other transactions (frontier) Jun 15, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants