Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure safe math for refunding weight #2346

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jun 12, 2023

What does it do?

uses checked-sub in refund weight

@nbaztec nbaztec added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes labels Jun 12, 2023
@github-actions
Copy link
Contributor

Coverage generated "Mon Jun 12 20:07:08 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2346/html/index.html

Master coverage: 71.22%
Pull coverage: 71.22%

@librelois librelois merged commit a3e40a9 into master Jun 14, 2023
@librelois librelois deleted the nish-fix-checked-sub branch June 14, 2023 14:41
@crystalin crystalin changed the title [MOON-2455] use checked-sub in refund weight Ensure safe math for refunding weight Jun 15, 2023
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants