Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run docker-moonbeam on push events #2398

Merged
merged 3 commits into from
Jul 30, 2023
Merged

run docker-moonbeam on push events #2398

merged 3 commits into from
Jul 30, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Jul 18, 2023

What does it do?

runs docker-moonbeam on push events (and non-external pull_requests)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023 •
edited
Loading

Coverage generated "Sun Jul 30 20:10:06 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2398/html/index.html

Master coverage: 87.39%
Pull coverage: 87.41%

@nbaztec nbaztec added B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D2-notlive PR doesn't change runtime code (so can't be audited) labels Jul 18, 2023
@crystalin
Copy link
Collaborator

Does it mean tht anyone now can trigger the docker action by a push in their branch (even external repo?)

@nbaztec
Copy link
Contributor Author

nbaztec commented Jul 18, 2023 •
edited
Loading

Does it mean tht anyone now can trigger the docker action by a push in their branch (even external repo?)

No, we limit the push event to only master & perm- branches in https://github.com/PureStake/moonbeam/blob/master/.github/workflows/build.yml#L10

Edit: I'm unsure how this works on forks having these branches though - will check

@crystalin
Copy link
Collaborator

I don't think we need it, I've changed the CI in the new org and it seems to work fine

@crystalin
Copy link
Collaborator

I tested with a fork and the event is "pull_request" not "push" so it is good

@crystalin crystalin mentioned this pull request Jul 30, 2023
Closed
@crystalin crystalin merged commit 542fd51 into master Jul 30, 2023
16 of 17 checks passed
@crystalin crystalin deleted the nish-fix-docker-moonbeam-gha branch July 30, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgamundi fgamundi fgamundi approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes ci Continuous Integration pipeline D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbaztec @crystalin @fgamundi