Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20 XCM Gas limit override check and tests #2495

Merged
merged 6 commits into from
Sep 20, 2023
Merged

ERC20 XCM Gas limit override check and tests #2495

merged 6 commits into from
Sep 20, 2023

Conversation

fgamundi
Copy link
Contributor

@fgamundi fgamundi commented Sep 19, 2023 •
edited
Loading

What does it do?

Reinforces #2422 from future changes in XCM Junction::GeneralKey. Adds a length check on data field of the GeneralKey junction when trying to override the gas limit of an incoming ERC20 XCM transfer. Included test to catch future changes in the junction definition that might make data unbounded.

@fgamundi fgamundi changed the title ERC20 XCM Gas limit check and tests ERC20 XCM Gas limit override check and tests Sep 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2023 •
edited
Loading

Coverage generated "Wed Sep 20 09:10:41 UTC 2023":
https://d3ifz9vhxc2wtb.cloudfront.net/pulls/2495/html/index.html

Master coverage: 87.39%
Pull coverage:

@fgamundi fgamundi added A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes not-breaking Does not need to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Sep 20, 2023
@fgamundi fgamundi self-assigned this Sep 20, 2023
@fgamundi fgamundi marked this pull request as ready for review September 20, 2023 07:33
@fgamundi fgamundi merged commit b08aa99 into master Sep 20, 2023
47 checks passed
@fgamundi fgamundi deleted the fg-check-grlkey-size branch September 20, 2023 17:02
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agusrodri Agusrodri Agusrodri approved these changes

@tmpolaczyk tmpolaczyk tmpolaczyk approved these changes

@librelois librelois librelois approved these changes

@notlesh notlesh notlesh approved these changes

@crystalin crystalin Awaiting requested review from crystalin

Assignees

@fgamundi fgamundi

Labels
A0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fgamundi @notlesh @librelois @tmpolaczyk @Agusrodri